linux-kernel - sparc64 MM regression...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180315.152815.1012910593389921933.davem@davemloft.net>
Date:   Thu, 15 Mar 2018 15:28:15 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     nitin.m.gupta@...cle.com
CC:     sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: sparc64 MM regression...

So I bisected a userspace corruption regression down to commit:

commit a8e654f01cb725d0bfd741ebca1bf4c9337969cc                                                                                    
Author: Nitin Gupta <nitin.m.gupta@...cle.com>                                                                                     
Date:   Wed Jan 31 16:18:09 2018 -0800                                                                                             

    sparc64: update pmdp_invalidate() to return old pmd value                                                                      

The transformation is basically from a set_pte_at() call into
an atomic cmpxchg64() loop to set the pmd.

The problem is that set_pmd_at() does more than just assign
the pmd entry.

It also does some accounting and also queues up a batch TLB
flush entry.

So the side effect of this change is that the TLB is never
flushed for these changed PMDs, and thus the userland memory
corruption I was seeing.