linux-kernel - Re: [PATCH v1 1/2] tracing: Improve design of preemptirq tracepoints and its users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201803160351.YXuH1FAL%fengguang.wu@intel.com>
Date:   Fri, 16 Mar 2018 03:51:25 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Joel Fernandes <joelaf@...gle.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Joel Fernandes <joelaf@...gle.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Peter Zilstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v1 1/2] tracing: Improve design of preemptirq tracepoints
 and its users

Hi Joel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc5 next-20180315]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Joel-Fernandes/tracing-Improve-design-of-preemptirq-tracepoints-and-its-users/20180316-012211
config: i386-randconfig-x006-201810 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   kernel//locking/lockdep.c: In function 'lockdep_init':
>> kernel//locking/lockdep.c:4325:2: error: implicit declaration of function 'register_trace_irq_disable'; did you mean 'trace_irq_disable'? [-Werror=implicit-function-declaration]
     register_trace_irq_disable(lockdep_hardirqs_off, NULL);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
     trace_irq_disable
>> kernel//locking/lockdep.c:4326:2: error: implicit declaration of function 'register_trace_irq_enable'; did you mean 'register_trace_lock_release'? [-Werror=implicit-function-declaration]
     register_trace_irq_enable(lockdep_hardirqs_on, NULL);
     ^~~~~~~~~~~~~~~~~~~~~~~~~
     register_trace_lock_release
   cc1: some warnings being treated as errors

vim +4325 kernel//locking/lockdep.c

  4321	
  4322	void __init lockdep_init(void)
  4323	{
  4324	#ifdef CONFIG_PROVE_LOCKING
> 4325		register_trace_irq_disable(lockdep_hardirqs_off, NULL);
> 4326		register_trace_irq_enable(lockdep_hardirqs_on, NULL);
  4327	#endif
  4328		printk("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
  4329	
  4330		printk("... MAX_LOCKDEP_SUBCLASSES:  %lu\n", MAX_LOCKDEP_SUBCLASSES);
  4331		printk("... MAX_LOCK_DEPTH:          %lu\n", MAX_LOCK_DEPTH);
  4332		printk("... MAX_LOCKDEP_KEYS:        %lu\n", MAX_LOCKDEP_KEYS);
  4333		printk("... CLASSHASH_SIZE:          %lu\n", CLASSHASH_SIZE);
  4334		printk("... MAX_LOCKDEP_ENTRIES:     %lu\n", MAX_LOCKDEP_ENTRIES);
  4335		printk("... MAX_LOCKDEP_CHAINS:      %lu\n", MAX_LOCKDEP_CHAINS);
  4336		printk("... CHAINHASH_SIZE:          %lu\n", CHAINHASH_SIZE);
  4337	
  4338		printk(" memory used by lock dependency info: %lu kB\n",
  4339			(sizeof(struct lock_class) * MAX_LOCKDEP_KEYS +
  4340			sizeof(struct list_head) * CLASSHASH_SIZE +
  4341			sizeof(struct lock_list) * MAX_LOCKDEP_ENTRIES +
  4342			sizeof(struct lock_chain) * MAX_LOCKDEP_CHAINS +
  4343			sizeof(struct list_head) * CHAINHASH_SIZE
  4344	#ifdef CONFIG_PROVE_LOCKING
  4345			+ sizeof(struct circular_queue)
  4346	#endif
  4347			) / 1024
  4348			);
  4349	
  4350		printk(" per task-struct memory footprint: %lu bytes\n",
  4351			sizeof(struct held_lock) * MAX_LOCK_DEPTH);
  4352	}
  4353	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28276 bytes)