linux-kernel - Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f0bd797-64d4-ae96-00ae-5e11cf74d28e@grandegger.com>
Date:   Thu, 15 Mar 2018 07:58:35 +0100
From:   Wolfgang Grandegger <wg@...ndegger.com>
To:     Jakob Unterwurzacher <jakob.unterwurzacher@...obroma-systems.com>
Cc:     Martin Elshuber <martin.elshuber@...obroma-systems.com>,
        Philipp Tomsich <philipp.tomsich@...obroma-systems.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        linux-can@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN
 devices



Am 14.03.2018 um 20:07 schrieb Jakob Unterwurzacher:
> On 14.03.18 11:04, Wolfgang Grandegger wrote:
>>>>  (000.000443)  can0  20000034   [8]  00 0C 00 00 00 00 78 00   
>>>> ERRORFRAME
>>>>     controller-problem{rx-error-warning,tx-error-warning}
>>>>     transceiver-status
>>>>     no-acknowledgement-on-tx
>>>>     error-counter-tx-rx{{120}{0}}
>>>>  (000.000444)  can0  20000034   [8]  00 3C 00 00 00 00 80 00   
>>>> ERRORFRAME
>>>>     
>>>> controller-problem{rx-error-warning,tx-error-warning,rx-error-passive,tx-error-passive} 
>>
>>
>> Just,
>>
>>        controller-problem{rx-error-passive,tx-error-passive} [...]
>>
>> Back to error active is missing!?
> 
> That was indeed missing. We have fixed the missing back-to-error-active 
> in our firmware.
> 
> Also, we no longer send the controller status in every error frame, but 
> only on state changes (see below) which seems to be how other drivers 
> are handling things.

Good, it would also be useful, if berr-reporting could be enabled by the 
firmware. This avoids a lot of traffic and load, especially if no cable 
is connected.

Wolfgang.