linux-kernel - [PATCH 2/2 v2] mtd: ubi: use put_device() if device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1521098431-29565-1-git-send-email-arvind.yadav.cs@gmail.com>
Date:   Thu, 15 Mar 2018 12:50:31 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     dwmw2@...radead.org, computersforpeace@...il.com,
        boris.brezillon@...e-electrons.com, marek.vasut@...il.com,
        richard@....at, cyrille.pitchen@...ev4u.fr, dedekind1@...il.com
Cc:     linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: [PATCH 2/2 v2] mtd: ubi: use put_device() if device_register fail

if device_register() returned an error! Always use put_device()
to give up the reference initialized.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
---
change in v2:
        Fix use-after-free bug. move put_device() after cdev_del().

 drivers/mtd/ubi/vmt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index 3fd8d7f..93c6163 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -610,6 +610,7 @@ int ubi_add_volume(struct ubi_device *ubi, struct ubi_volume *vol)
 
 out_cdev:
 	cdev_del(&vol->cdev);
+	put_device(&vol->dev);
 	return err;
 }
 
-- 
1.9.1