linux-kernel - Re: [PATCH] [v2] y2038: introduce struct __kernel_old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1803150943130.1525@nanos.tec.linutronix.de>
Date:   Thu, 15 Mar 2018 09:44:21 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Arnd Bergmann <arnd@...db.de>
cc:     lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        John Stultz <john.stultz@...aro.org>,
        Miroslav Lichvar <mlichvar@...hat.com>,
        Richard Cochran <richardcochran@...il.com>,
        Prarit Bhargava <prarit@...hat.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Deepa Dinamani <deepa.kernel@...il.com>
Subject: Re: [PATCH] [v2] y2038: introduce struct __kernel_old_timeval

On Wed, 14 Mar 2018, Arnd Bergmann wrote:
>  
>  /*
> + * legacy timeval structure, only embedded in structures that
> + * traditionally used 'timeval' to pass time intervals (not absolute
> + * times). Do not add new users. If user space fails to compile
> + * here, this is probably because it is not y2038 safe and needs to
> + * be changed to use another interface.
> + */
> +struct __kernel_old_timeval {
> +	__kernel_long_t tv_sec;			/* seconds */
> +	__kernel_long_t tv_usec;		/* microseconds */

Please don't use these horrible tail comments. If you want to document the
obvious, then please use proper kernel doc.

Thanks,

	tglx