linux-kernel - Re: [PATCH v2 1/2] trace_uprobe: Use %lx to display offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Mar 2018 18:29:14 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Cc:     rostedt@...dmis.org, linux-kernel@...r.kernel.org,
        keescook@...omium.org, wangnan0@...wei.com, mingo@...hat.com,
        srikar@...ux.vnet.ibm.com, oleg@...hat.com, mhiramat@...nel.org,
        namhyung@...nel.org
Subject: Re: [PATCH v2 1/2] trace_uprobe: Use %lx to display offset

On Thu, 15 Mar 2018 13:57:55 +0530
Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com> wrote:

> tu->offset is unsigned long, not a pointer, thus %lx should
> be used to print it, not the %px.
> 

This looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks,

> Fixes: 0e4d819d0893 ("trace_uprobe: Display correct offset in uprobe_events")
> Suggested-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
> ---
> v2 changelog:
>  - Keep prefixed 0s as is.
> 
>  kernel/trace/trace_uprobe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 2014f4351ae0..0298bd15be83 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -608,7 +608,7 @@ static int probes_seq_show(struct seq_file *m, void *v)
>  
>  	/* Don't print "0x  (null)" when offset is 0 */
>  	if (tu->offset) {
> -		seq_printf(m, "0x%px", (void *)tu->offset);
> +		seq_printf(m, "0x%0*lx", (int)(sizeof(void *) * 2), tu->offset);
>  	} else {
>  		switch (sizeof(void *)) {
>  		case 4:
> -- 
> 2.13.6
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>