linux-kernel - Re: [PATCH] x86: vdso: eliminate some redundant loads in update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Mar 2018 10:39:18 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
cc:     Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: vdso: eliminate some redundant loads in
 update_vsyscall

On Thu, 15 Mar 2018, Rasmus Villemoes wrote:
> diff --git a/arch/x86/entry/vsyscall/vsyscall_gtod.c b/arch/x86/entry/vsyscall/vsyscall_gtod.c
> index e1216dd95c04..550447a43a50 100644
> --- a/arch/x86/entry/vsyscall/vsyscall_gtod.c
> +++ b/arch/x86/entry/vsyscall/vsyscall_gtod.c
> @@ -31,6 +31,7 @@ void update_vsyscall(struct timekeeper *tk)
>  {
>  	int vclock_mode = tk->tkr_mono.clock->archdata.vclock_mode;
>  	struct vsyscall_gtod_data *vdata = &vsyscall_gtod_data;
> +	int shift;

Not that it is a big issue, but the shift value in the timekeeper is
unsigned. So please use an unsigned here as well.

Thanks,

	tglx