linux-kernel - Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180315112454.7p6gch4gq7jljk37@mwanda>
Date:   Thu, 15 Mar 2018 14:24:54 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     NeilBrown <neil@...wn.name>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, lkml <linux-kernel@...r.kernel.org>,
        John Crispin <john@...ozen.org>
Subject: Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in
 gnubee-pc1

On Thu, Mar 15, 2018 at 10:04:33PM +1100, NeilBrown wrote:
> On Thu, Mar 15 2018, Dan Carpenter wrote:
> 
> > This all seems fine.  Generally the requirements for staging are that it
> > has a TODO, someone to work on it, and it doesn't break the build.  But
> > some of the patches don't have commit message and those are required and
> > some of the commit messages are just the changes you have made not don't
> > describe the actual code...
> 
> Thanks for having a look.
> It seems odd to require detailed commit messages, when we don't require
> the same level of quality in the code.
> Naturally when the driver is moved out of staging a properly detailed
> commit message should be added, but is that needed on the way in to
> staging?  At this stage I don't know much more than is already there.
> After I've cleaned up the code I probably will.
> 
> For patch 01/13 you asked "what kind of device this is".  The subject
> line makes it clear that it is a "pcie driver".  What extra detail did
> you want?  Would it be sufficient to just copy the subject line so that
> it appears twice in the commit message?
> 

Ah...  Sorry.  It's literally a pcie driver.  For some reason I thought
it was a device that ran over pcie.

We don't require a detailed changelog, but you have to put something...
Probably just restating the subject and adding that it's for the gnubee1
is fine.

regards,
dan carpenter