linux-kernel - Re: [PATCH 0/3] Introduce module_nd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4jj5HBJOBFNcWMGRg5DufLKJj-=BCVVORWpVno9p270Zg@mail.gmail.com>
Date:   Thu, 15 Mar 2018 07:24:37 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux NV-DIMM Mailing List <linux-nvdimm@...ts.01.org>
Subject: Re: [PATCH 0/3] Introduce module_nd_driver

On Thu, Mar 15, 2018 at 1:11 AM, Johannes Thumshirn <jthumshirn@...e.de> wrote:
> On Thu, Mar 15, 2018 at 12:22:57AM -0700, Christoph Hellwig wrote:
>> What is the point?  It saves a hand fulk of lines, while making
>> the code both harder to read and harder to extend.
>
> In the end it's just style alignment with most of the other "busses"
> in the kernel, like pci, of, acpi, platform and so on...
>
> But yes I admit it's not a huge win. For the harder to read part, I
> doubt it. A quick:
> git grep -E module_.*._driver drivers/ | wc -l
> has 3896 hit's, so it's not that uncommon ;-)
>
> But anyways, it's just code churn I came up with while being
> frustrated hunting down a bug in this subsystem.
>

Works for me. Removing more lines than you add is always welcome.