linux-kernel - Re: [PATCH] net: ethernet: ti: cpsw: add check for in-band mode setting with RGMII PHY interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180315143102.GA28577@lunn.ch>
Date:   Thu, 15 Mar 2018 15:31:02 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     "SZ Lin (?????????)" <sz.lin@...a.com>
Cc:     Schuyler Patton <spatton@...com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        "David S. Miller" <davem@...emloft.net>,
        Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
        Keerthy <j-keerthy@...com>, Sekhar Nori <nsekhar@...com>,
        linux-omap@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: cpsw: add check for in-band mode
 setting with RGMII PHY interface

> @@ -1014,7 +1014,13 @@ static void _cpsw_adjust_link(struct cpsw_slave *slave,
>  		/* set speed_in input in case RMII mode is used in 100Mbps */
>  		if (phy->speed == 100)
>  			mac_control |= BIT(15);
> -		else if (phy->speed == 10)
> +
> +		/* in band mode only works in 10Mbps RGMII mode */
> +		else if ((phy->speed == 10) &&
> +			 ((phy->interface == PHY_INTERFACE_MODE_RGMII) ||
> +			 (phy->interface == PHY_INTERFACE_MODE_RGMII_ID) ||
> +			 (phy->interface == PHY_INTERFACE_MODE_RGMII_RXID) ||
> +			 (phy->interface == PHY_INTERFACE_MODE_RGMII_TXID)))

Please use phy_interface_mode_is_rgmii()

	Andrew