linux-kernel - Re: Atheros 1525/QCA6174 BT issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h4llh72oz.wl-tiwai@suse.de>
Date:   Thu, 15 Mar 2018 16:56:12 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Linux Bluetooth mailing list 
        <linux-bluetooth@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ivan Levshin <ivan.levshin@...rofocus.com>
Subject: Re: Atheros 1525/QCA6174 BT issue

On Tue, 13 Mar 2018 10:15:26 +0100,
Marcel Holtmann wrote:
> 
> Hi Takashi,
> 
> >>>>>>>> we've got a but report about the broken Atheros BT on the recent
> >>>>>>>> kernels:
> >>>>>>>> http://bugzilla.opensuse.org/show_bug.cgi?id=1082504
> >>>>>>>> 
> >>>>>>>> In short, btusb can't load the patch ar3k/AthrBT_0x00000200.dfu, and
> >>>>>>>> this could be worked around by the patch to move 0cf3:3004 blacklist
> >>>>>>>> entry to use BTUSB_QCA_ROM instead of BTUSB_ATH3012.
> >>>>>>>> 
> >>>>>>>> And this looks like a long-standing problem, at least for over two
> >>>>>>>> years.  Many web pages suggest the same patch, but it's never merged
> >>>>>>>> to upstream.
> >>>>>>>> 
> >>>>>>>> So this made me wonder what's going on.  I see that the BTUSB_ATH3012
> >>>>>>>> quirk was originally introduced just for this chip id (0cf3:3004).
> >>>>>>>> Is it a different variant from the original chip that causes a
> >>>>>>>> problem?
> >>>>>>> 
> >>>>>>> not all patches from distro kernel are sent upstream. I have not heard of this specific issues, but happy to accept patches to get it fixed.
> >>>>>> 
> >>>>>> OK, basically it's like below.
> >>>>>> But, as mentioned, this made me wonder whether it's the right fix.
> >>>>>> The BTUSB_ATH3012 quirk was introduced exactly for this chip ID
> >>>>>> (0cf3:3004), and now this chip is moved to another quirk...
> >>>>>> 
> >>>>>> If this is the right move, I can re-submit via git-send-email, too.
> >>>>>> Just let me know.
> >>>>> 
> >>>>> Marcel, could you take a look at this?
> >>>>> If it sucks, let's seek for a better solution.
> >>>> 
> >>>> wasn’t the confusion that this is fixed with a recent kernel? I am lost in this thread. I mean if people add Tested-by, then I can take this as well. Otherwise we might need someone from Qualcomm to shed some light into these.
> >>> 
> >>> Well, *this* thread is likely different from the recent other
> >>> threads.
> >>> 
> >>> Isn't 4.15.7 recent enough?  At least, it already contains the
> >>> backport of relevant fixes:
> >>>   Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"
> >>>   Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a
> >>>     "rewritten" version
> >>> 
> >>> (And it's not Yoga but MSI GS40 laptop, so DMI doesn't matter.)
> >>> According to Ivan, the reporter of the bug (now Cc'ed), 4.15.7 didn't
> >>> work without the patch, so the problem is still there, as it seems.
> >>> 
> >>> In anyway, I'm going to build a kernel with my patch on top of 4.15.9
> >>> for testing again.  Maybe also a patched 4.16-rc5 kernel, too.  If
> >>> it's confirmed, will report back with tested-by tag.
> >> 
> >> I think there are two patches that are not yet in Linus’ tree and waiting in Dave’s net tree. We actually removed the Yoga DMI entry again since it was found that it is not needed. However there is a Dell OptiPlex entry that was needed.
> >> 
> >> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=0c6e526646c04ce31d4aaa280ed2237dd1cd774c
> > 
> > In our case, the target machine is a MSI laptop, so these changes
> > should be irrelevant.  Or do you suggest to try the same DMI reset
> > quirk matching with the MSI machine?
> 
> that is maybe needed.

OK, now the results:

4.15.9 vanilla -> BAD
4.16-rc5 vanilla -> BAD
4.16-rc5 with DMI quirk -> BAD

So, btusb_needs_reset_resume_table[] doesn't help in our case.

And the patch was confirmed to work on both 4.15.9 and 4.16-rc5.

I'll resubmit the patch.


thanks,

Takashi