[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180315133156.3389b762@vmware.local.home>
Date: Thu, 15 Mar 2018 13:31:56 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: changbin.du@...el.com, jolsa@...hat.com, peterz@...radead.org,
mingo@...hat.com, namhyung@...nel.org, yan.y.zhao@...el.com,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf trace: __print_array should print hex format
instead of dec
On Thu, 15 Mar 2018 13:20:25 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:
> On Tue, 13 Mar 2018 11:27:32 -0300
> Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>
> > Em Tue, Mar 13, 2018 at 06:39:17PM +0800, changbin.du@...el.com escreveu:
> > > From: Changbin Du <changbin.du@...el.com>
> > >
> > > The token '__print_array' is to print the array in hex format, but not
> > > decimal numbers. The implementation of __print_array in kernel side is:
> > > __print_array()->trace_print_array_seq()
> > >
> > > This patch align the perf's behavior with kernel so we have a consistent
> > > event format.
> >
> > Look ok, i.e. makes the userspace formatting do what the equivalent
> > kernel code does, Rostedt, Ack?
> >
>
> Thanks for sending this to me. I'll see how it affects trace-cmd, and
> let you know.
>
Looks good!
Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
-- Steve
Powered by blists - more mailing lists