linux-kernel - Re: [PATCH] scsi: scsi_transport_iscsi: use put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq17eqe9dwp.fsf@oracle.com>
Date:   Thu, 15 Mar 2018 00:11:02 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     lduncan@...e.com, cleech@...hat.com
Cc:     Arvind Yadav <arvind.yadav.cs@...il.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, linux-kernel@...r.kernel.org,
        open-iscsi@...glegroups.com, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()


> Never directly free @dev after calling device_register(), even
> if it returned an error! Always use put_device() to give up the
> reference initialized.

Lee, Chris: Please review!

-- 
Martin K. Petersen	Oracle Linux Engineering