linux-kernel - Re: [PATCH v2 2/2] clk: aspeed: Prevent reset if clock is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <152113767831.111154.2144307841968232404@swboyd.mtv.corp.google.com>
Date:   Thu, 15 Mar 2018 11:14:38 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Eddie James <eajames@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Cc:     linux-clk@...r.kernel.org, joel@....id.au, mturquette@...libre.com,
        eajames@...ux.vnet.ibm.com, mine260309@...il.com,
        ryan_chen@...eedtech.com
Subject: Re: [PATCH v2 2/2] clk: aspeed: Prevent reset if clock is enabled

Quoting Eddie James (2018-03-08 12:57:20)
> According to the Aspeed specification, the reset and enable sequence
> should be done when the clock is stopped. The specification doesn't
> define behavior if the reset is done while the clock is enabled.
> 
> From testing on the AST2500, the LPC Controller has problems if the
> clock is reset while enabled.
> 
> Therefore, check whether the clock is enabled or not before performing
> the reset and enable sequence in the Aspeed clock driver.
> 
> Root-caused-by: Lei Yu <mine260309@...il.com>
> Signed-off-by: Eddie James <eajames@...ux.vnet.ibm.com>
> ---

Applied to clk-fixes