linux-kernel - Re: [PATCH 14/14] Input: atmel_mxt_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180316204141.GB24333@bm.shmanahar.org>
Date:   Fri, 16 Mar 2018 20:41:41 +0000
From:   Nick Dyer <nick@...anahar.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-input@...r.kernel.org, Benson Leung <bleung@...omium.org>,
        Olof Johansson <olof@...om.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/14] Input: atmel_mxt_ts - remove platform data support

On Thu, Mar 15, 2018 at 05:06:14PM -0700, Dmitry Torokhov wrote:
> On Wed, Mar 14, 2018 at 08:59:38PM +0000, Nick Dyer wrote:
> > On Mon, Mar 12, 2018 at 12:09:07PM -0700, Dmitry Torokhov wrote:
> > > -	/*
> > > -	 * Ignore ACPI devices representing bootloader mode.
> > > -	 *
> > > -	 * This is a bit of a hack: Google Chromebook BIOS creates ACPI
> > > -	 * devices for both application and bootloader modes, but we are
> > > -	 * interested in application mode only (if device is in bootloader
> > > -	 * mode we'll end up switching into application anyway). So far
> > > -	 * application mode addresses were all above 0x40, so we'll use it
> > > -	 * as a threshold.
> > > -	 */
> > > -	if (client->addr < 0x40)
> > > -		return -ENXIO;
> > 
> > Could you use 0x4a, since that's the lowest application mode address,
> > same in the other place.
> 
> OK, this is existing code though, so I'll make a separate patch.

Ah, I see now. In which case it's no big deal.

Acked-by: Nick Dyer <nick@...anahar.org>