linux-kernel - Re: linux-next: build warning after merge of the tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b2382ce-c51d-38b5-5c9b-4386e603ac68@cn.fujitsu.com>
Date:   Fri, 16 Mar 2018 14:04:08 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>
CC:     Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>
Subject: Re: linux-next: build warning after merge of the tip tree

Hi Stephen,

At 03/16/2018 01:52 PM, Dou Liyang wrote:
> Hi Stephen,
> 
> At 03/16/2018 01:37 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the tip tree, yesterday's linux-next build (x86_64 
>> allnoconfig)
>> produced this warning:
>>
>> kernel/cpu.c:129:13: warning: 'cpuhp_is_ap_state' defined but not used 
>> [-Wunused-function]
>>   static bool cpuhp_is_ap_state(enum cpuhp_state state)
>>               ^~~~~~~~~~~~~~~~~
>>
> 
> Yes, Jiangshan has replaced it with cpuhp_hp_states. So it is obsolete,
> it should be removed.
> 

I made a mistake, It also be called by cpuhp_thread_fun() and
cpuhp_issue_call(), let me have a look carefully.

Thanks,
	dou.

> Thanks,
>      dou.
>> Introduced by commit
>>
>>    17a2f1ced028 ("cpu/hotplug: Merge cpuhp_bp_states and 
>> cpuhp_ap_states")
>>