linux-kernel - Re: [PATCH] ARM: davinci: DA8XX: fix oops in USB PHY driver due to stack allocated platform platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <382a269a-f486-8c1a-23b2-9620a01a073c@ti.com>
Date:   Fri, 16 Mar 2018 15:47:14 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     David Lechner <david@...hnology.com>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     Kevin Hilman <khilman@...nel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: davinci: DA8XX: fix oops in USB PHY driver due to
 stack allocated platform platform_data

On Thursday 15 March 2018 11:32 PM, David Lechner wrote:
> This fixes a possible kernel oops due to using stack allocated platform
> data for the USB PHY driver on DA8XX devices. If the platform device
> probe is deferred, then we get a corrupt pointer for the platform data.
> 
> We now use a global static struct for the platform data so that the
> platform data pointer does not get written over.
> 
> Tested on OMAP-L138 LCDK board using legacy board file.

Oops. That should have been caught in review.

> 
> Fixes: 9b504750923cb ("ARM: davinci: da8xx: Add USB PHY platform device")

The offending commit seems to be bdec5a6b5789 ("ARM: da8xx: use platform
data for CFGCHIP syscon regmap") in my tree which should be in
linux-next. I don't think we have this issue in mainline. Right?

> Signed-off-by: David Lechner <david@...hnology.com>

Thanks,
Sekhar