linux-kernel - Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180316102931.GA28344@archlinux>
Date:   Fri, 16 Mar 2018 15:59:31 +0530
From:   Pratik Jain <pratik.jain0509@...il.com>
To:     Ian Abbott <abbotti@....co.uk>
Cc:     linux-kernel@...r.kernel.org, greg@...ah.com,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line
 derefernce issue

Yes that can be done. But isn't 80 column limit more of a
historical convention?

On Fri, Mar 16, 2018 at 10:17:28AM +0000, Ian Abbott wrote:
> On 15/03/2018 18:59, Pratik Jain wrote:
> > Fixed coding style issue.
> > 
> > Signed-off-by: Pratik Jain <pratik.jain0509@...il.com>
> > ---
> >   drivers/staging/comedi/drivers/ni_atmio.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
> > index b9e9ab548c4b..4e27a2959b64 100644
> > --- a/drivers/staging/comedi/drivers/ni_atmio.c
> > +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> > @@ -226,8 +226,8 @@ static int ni_isapnp_find_board(struct pnp_dev **dev)
> >   	for (i = 0; i < ARRAY_SIZE(ni_boards); i++) {
> >   		isapnp_dev = pnp_find_dev(NULL,
> >   					  ISAPNP_VENDOR('N', 'I', 'C'),
> > -					  ISAPNP_FUNCTION(ni_boards[i].
> > -							  isapnp_id), NULL);
> > +					  ISAPNP_FUNCTION(ni_boards[i].isapnp_id),
> > +					  NULL);
> >   		if (!isapnp_dev || !isapnp_dev->card)
> >   			continue;
> > 
> 
> I suggest splitting the expression just after the '=' to avoid going over 80
> columns.
> 
> -- 
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
> -=(                          Web: http://www.mev.co.uk/  )=-