linux-kernel - Re: [PATCH v3] mfd: rk808: Add restart functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5cec78da-9b76-12fa-703a-bbaa90a6d58c@phytec.de>
Date:   Fri, 16 Mar 2018 12:49:08 +0100
From:   Wadim Egorov <w.egorov@...tec.de>
To:     Daniel Schultz <d.schultz@...tec.de>, lee.jones@...aro.org
Cc:     zhangqing@...k-chips.com, xsf@...k-chips.com,
        tony.xie@...k-chips.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mfd: rk808: Add restart functionality

Hi Daniel,

Am 16.03.2018 um 09:26 schrieb Daniel Schultz:
> When using Rockchip SoCs with rk805/808/818 PMICs, restarts are realized by
> setting the reset registers in the "Clock and Reset Unit".
>
> Since all three shutdown functions have almost the same code, all logic
> from the shutdown functions can be refactored to a new function
> "rk808_update_bits", which can update a register by a given address and
> bitmask.
>
> After that, notifier blocks and the restart functions were added to the
> driver. Like the shutdown function, the restart is bound to the
> "rockchip,system-power-controller" device tree property and can easily
> revoked to the software restart by removing the property.
can you please split the changes into separate patches? One patch for
the refactoring of the shutdown functions and one for the new
system-reset-controller binding.

Regards,
Wadim