linux-kernel - Re: [PATCH v2 2/7] kbuild: remove wrong 'touch' in adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YSQ.7.76.1803152224090.28583@knanqh.ubzr>
Date:   Thu, 15 Mar 2018 22:24:32 -0400 (EDT)
From:   Nicolas Pitre <nicolas.pitre@...aro.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/7] kbuild: remove wrong 'touch' in
 adjust_autoksyms.sh

On Fri, 16 Mar 2018, Masahiro Yamada wrote:

> The comment mentions it creates autoksyms.h in case it is missing,
> but the actual code touches it when it does exists.
> 
> The build system creates it anyway because <linux/export.h> and
> <asm-generic/export.h> need it.
> 
> The code would not have worked as intended, and people have not
> noticed it.  This is a proof that we can simply remove it.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Acked-by: Nicolas Pitre <nico@...aro.org>

> ---
> 
> Changes in v2:
>   - Remove the code instead of fixing it
> 
>  scripts/adjust_autoksyms.sh | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh
> index a162258..e0dd0d5 100755
> --- a/scripts/adjust_autoksyms.sh
> +++ b/scripts/adjust_autoksyms.sh
> @@ -48,9 +48,6 @@ case "${KCONFIG_CONFIG}" in
>  	. "./${KCONFIG_CONFIG}"
>  esac
>  
> -# In case it doesn't exist yet...
> -if [ -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi
> -
>  # Generate a new ksym list file with symbols needed by the current
>  # set of modules.
>  cat > "$new_ksyms_file" << EOT
> -- 
> 2.7.4
> 
>