linux-kernel - Re: [PATCH 2/4] mm/hmm: fix header file if/else/endif maze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Mar 2018 08:53:11 +0800
From:   kbuild test robot <lkp@...el.com>
To:     jglisse@...hat.com
Cc:     kbuild-all@...org, linux-mm@...ck.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Jérôme Glisse <jglisse@...hat.com>,
        Ralph Campbell <rcampbell@...dia.com>,
        John Hubbard <jhubbard@...dia.com>,
        Evgeny Baskakov <ebaskakov@...dia.com>
Subject: Re: [PATCH 2/4] mm/hmm: fix header file if/else/endif maze

Hi Jérôme,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc5 next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/jglisse-redhat-com/mm-hmm-documentation-editorial-update-to-HMM-documentation/20180317-074102
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from kernel/fork.c:40:0:
>> include/linux/hmm.h:515:20: error: redefinition of 'hmm_mm_destroy'
    static inline void hmm_mm_destroy(struct mm_struct *mm) {}
                       ^~~~~~~~~~~~~~
   include/linux/hmm.h:502:20: note: previous definition of 'hmm_mm_destroy' was here
    static inline void hmm_mm_destroy(struct mm_struct *mm) {}
                       ^~~~~~~~~~~~~~
>> include/linux/hmm.h:516:20: error: redefinition of 'hmm_mm_init'
    static inline void hmm_mm_init(struct mm_struct *mm) {}
                       ^~~~~~~~~~~
   include/linux/hmm.h:503:20: note: previous definition of 'hmm_mm_init' was here
    static inline void hmm_mm_init(struct mm_struct *mm) {}
                       ^~~~~~~~~~~

vim +/hmm_mm_destroy +515 include/linux/hmm.h

133ff0eac Jérôme Glisse 2017-09-08  509  
133ff0eac Jérôme Glisse 2017-09-08  510  static inline void hmm_mm_init(struct mm_struct *mm)
133ff0eac Jérôme Glisse 2017-09-08  511  {
133ff0eac Jérôme Glisse 2017-09-08  512  	mm->hmm = NULL;
133ff0eac Jérôme Glisse 2017-09-08  513  }
6b368cd4a Jérôme Glisse 2017-09-08  514  #else /* IS_ENABLED(CONFIG_HMM_MIRROR) */
6b368cd4a Jérôme Glisse 2017-09-08 @515  static inline void hmm_mm_destroy(struct mm_struct *mm) {}
6b368cd4a Jérôme Glisse 2017-09-08 @516  static inline void hmm_mm_init(struct mm_struct *mm) {}
6b368cd4a Jérôme Glisse 2017-09-08  517  #endif /* IS_ENABLED(CONFIG_HMM_MIRROR) */
133ff0eac Jérôme Glisse 2017-09-08  518  

:::::: The code at line 515 was first introduced by commit
:::::: 6b368cd4a44ce95b33f1d31f2f932e6ae707f319 mm/hmm: avoid bloating arch that do not make use of HMM

:::::: TO: Jérôme Glisse <jglisse@...hat.com>
:::::: CC: Linus Torvalds <torvalds@...ux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (6733 bytes)