linux-kernel - Re: [PATCH v2 15/36] fs: add ksys_umount() helper; remove in-kernel call to sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180317165808.GB2226@light.dominikbrodowski.net>
Date:   Sat, 17 Mar 2018 17:58:08 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        viro@...iv.linux.org.uk, luto@...nel.org, mingo@...nel.org,
        akpm@...ux-foundation.org, arnd@...db.de
Subject: Re: [PATCH v2 15/36] fs: add ksys_umount() helper; remove in-kernel
 call to sys_umount()

On Fri, Mar 16, 2018 at 01:47:50AM -0700, Christoph Hellwig wrote:
> On Thu, Mar 15, 2018 at 08:05:08PM +0100, Dominik Brodowski wrote:
> > Using this helper allows us to avoid the in-kernel call to the sys_umount()
> > syscall.
> 
> kern_unmount, please.  And make it operate on kernel pointers please.

On the naming issue, see my other message from a few days ago. Concerning
the added complexity and the need-for-cleanup in init/do_mounts_initrd.c, I
have added the following comment:

	In the near future, the only fs-external caller of ksys_umount() should be
	converted to call do_umount() directly. Then, ksys_umount() can be moved
	within sys_umount() again.

Thanks,
	Dominik