linux-kernel - Re: [PATCH v7 0/2] hwmon: (ucd9000) Add gpio and debugfs interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7aab7e3-4ebc-c816-f50e-4c6f06e89e95@roeck-us.net>
Date:   Fri, 16 Mar 2018 18:53:40 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Eddie James <eajames@...ux.vnet.ibm.com>,
        linux-hwmon@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, jdelvare@...e.com, joel@....id.au
Subject: Re: [PATCH v7 0/2] hwmon: (ucd9000) Add gpio and debugfs interfaces

On 03/16/2018 02:22 PM, Eddie James wrote:
> The ucd9000 series chips have gpio pins. Add a gpio chip interface to the ucd
> device so that users can query and set the state of the gpio pins.
> 
> Add a debugfs interface using the existing pmbus debugfs directory to provide
> MFR_STATUS and the status of the gpi faults to users.
> 

Series applied to hwmon-next. Thanks a lot for your patience.

Guenter

> Changes since v6:
>   - don't return null terminator for mfr_status
> 
> Changes since v5:
>   - enclose gpio code in #ifdef GPIOLIB
>   - don't initialize buffers for mfr_status; set last char to 0 instead
>   - cap the size argument to bin2hex
> 
> Changes since v4:
>   - max-sized buffers for smbus transfers
>   - used bin2hex instead of my own code
> 
> Changes since v3:
>   - remove setting of gpio_chip->owner
>   - format the mfr_status data
>   - switch to #ifdef rather than #if IS_ENABLED for debugfs
> 
> Changes since v2:
>   - split the gpio registration into it's own function
> 
> Changes since v1:
>   - dropped dev_err messages
>   - made gpio chip registration conditional on having gpio pins
>   - made mfr_status debugfs attribute more simple
> 
> 
> Christopher Bostic (2):
>    hwmon: (ucd9000) Add gpio chip interface
>    hwmon: (ucd9000) Add debugfs attributes to provide mfr_status
> 
>   drivers/hwmon/pmbus/ucd9000.c | 350 +++++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 349 insertions(+), 1 deletion(-)
>