linux-kernel - Re: [PATCH v2] rbd: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201803171504.nBUoBK9O%fengguang.wu@intel.com>
Date:   Sat, 17 Mar 2018 15:27:01 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Kyle Spiers <kyle@...ers.me>
Cc:     kbuild-all@...org, idryomov@...il.com, sage@...hat.com,
        elder@...nel.org, ceph-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, keescook@...omium.org, me@...in.cc,
        Kyle Spiers <kyle@...ers.me>
Subject: Re: [PATCH v2] rbd: Remove VLA usage

Hi Kyle,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc5 next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Kyle-Spiers/rbd-Remove-VLA-usage/20180317-131424
config: x86_64-randconfig-s0-03171325 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers//block/rbd.c: In function '__rbd_notify_op_lock':
   drivers//block/rbd.c:3105:2: error: expected ',' or ';' before 'void'
     void *p = buf;
     ^~~~
>> drivers//block/rbd.c:3110:23: error: 'p' undeclared (first use in this function)
     ceph_start_encoding(&p, 2, 1, buf_size - CEPH_ENCODING_START_BLK_LEN);
                          ^
   drivers//block/rbd.c:3110:23: note: each undeclared identifier is reported only once for each function it appears in

vim +/p +3110 drivers//block/rbd.c

b30a01f2a Ilya Dryomov 2014-05-22  3095  
ed95b21a4 Ilya Dryomov 2016-08-12  3096  static int __rbd_notify_op_lock(struct rbd_device *rbd_dev,
ed95b21a4 Ilya Dryomov 2016-08-12  3097  				enum rbd_notify_op notify_op,
ed95b21a4 Ilya Dryomov 2016-08-12  3098  				struct page ***preply_pages,
ed95b21a4 Ilya Dryomov 2016-08-12  3099  				size_t *preply_len)
b30a01f2a Ilya Dryomov 2014-05-22  3100  {
922dab613 Ilya Dryomov 2016-05-26  3101  	struct ceph_osd_client *osdc = &rbd_dev->rbd_client->client->osdc;
ed95b21a4 Ilya Dryomov 2016-08-12  3102  	struct rbd_client_id cid = rbd_get_cid(rbd_dev);
1910cf8b5 Kyle Spiers  2018-03-15  3103  	char buf[4 + 4 + 8 + 8 + CEPH_ENCODING_START_BLK_LEN];
1910cf8b5 Kyle Spiers  2018-03-15  3104  	int buf_size = sizeof(buf)
ed95b21a4 Ilya Dryomov 2016-08-12 @3105  	void *p = buf;
b30a01f2a Ilya Dryomov 2014-05-22  3106  
ed95b21a4 Ilya Dryomov 2016-08-12  3107  	dout("%s rbd_dev %p notify_op %d\n", __func__, rbd_dev, notify_op);
b30a01f2a Ilya Dryomov 2014-05-22  3108  
ed95b21a4 Ilya Dryomov 2016-08-12  3109  	/* encode *LockPayload NotifyMessage (op + ClientId) */
ed95b21a4 Ilya Dryomov 2016-08-12 @3110  	ceph_start_encoding(&p, 2, 1, buf_size - CEPH_ENCODING_START_BLK_LEN);
ed95b21a4 Ilya Dryomov 2016-08-12  3111  	ceph_encode_32(&p, notify_op);
ed95b21a4 Ilya Dryomov 2016-08-12  3112  	ceph_encode_64(&p, cid.gid);
ed95b21a4 Ilya Dryomov 2016-08-12  3113  	ceph_encode_64(&p, cid.handle);
76756a51e Ilya Dryomov 2014-06-20  3114  
ed95b21a4 Ilya Dryomov 2016-08-12  3115  	return ceph_osdc_notify(osdc, &rbd_dev->header_oid,
ed95b21a4 Ilya Dryomov 2016-08-12  3116  				&rbd_dev->header_oloc, buf, buf_size,
ed95b21a4 Ilya Dryomov 2016-08-12  3117  				RBD_NOTIFY_TIMEOUT, preply_pages, preply_len);
c525f0360 Ilya Dryomov 2016-04-28  3118  }
c525f0360 Ilya Dryomov 2016-04-28  3119  

:::::: The code at line 3110 was first introduced by commit
:::::: ed95b21a4b0a71ef89306cdeb427d53cc9cb343f rbd: support for exclusive-lock feature

:::::: TO: Ilya Dryomov <idryomov@...il.com>
:::::: CC: Ilya Dryomov <idryomov@...il.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (31625 bytes)