linux-kernel - Re: [PATCH v4 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE=gft6y4yUvjHnSf10+Yt9Sw-bcKdFUWW7zWFRvMgzENe7gUw@mail.gmail.com>
Date:   Sat, 17 Mar 2018 00:36:28 +0000
From:   Evan Green <evgreen@...omium.org>
To:     Lina Iyer <ilina@...eaurora.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-kernel@...r.kernel.org, sboyd@...nel.org
Subject: Re: [PATCH v4 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

On Fri, Mar 9, 2018 at 3:27 PM Lina Iyer <ilina@...eaurora.org> wrote:

> Active state requests are sent immediately to the mailbox controller,
> while sleep and wake state requests are cached in this driver to avoid
> taxing the mailbox controller repeatedly. The cached values will be sent
> to the controller when the rpmh_flush() is called.

> Generally, flushing is a system PM activity and may be called from the
> system PM drivers when the system is entering suspend or deeper sleep
> modes during cpuidle.

> Also allow invalidating the cached requests, so they may be re-populated
> again.

> Signed-off-by: Lina Iyer <ilina@...eaurora.org>
> ---

> Changes in v4:
>          - remove locking for ->dirty in invalidate
>          - fix send_single
> Changes in v3:
>          - Remove locking for flush function
>          - Improve comments
> ---
>   drivers/soc/qcom/rpmh.c | 203
+++++++++++++++++++++++++++++++++++++++++++++++-
>   include/soc/qcom/rpmh.h |  10 +++
>   2 files changed, 212 insertions(+), 1 deletion(-)


Reviewed-by: Evan Green <evgreen@...omium.org>