linux-kernel - Re: [PATCH] of: unittest: move misplaced function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180318124928.jl4w7u6uvshvacka@rob-hp-laptop>
Date:   Sun, 18 Mar 2018 07:49:28 -0500
From:   Rob Herring <robh@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Frank Rowand <frowand.list@...il.com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: unittest: move misplaced function declaration

On Tue, Mar 13, 2018 at 02:15:42PM +0100, Arnd Bergmann wrote:
> The overlay_data_apply() declaration is outside of the #ifdef that contains
> both the user and the definition, causing a compile-time warning in
> some configurations:
> 
> drivers/of/unittest.c:48:19: error: 'overlay_data_apply' declared 'static' but never defined [-Werror=unused-function]
>  static int __init overlay_data_apply(const char *overlay_name, int *overlay_id);
> 
> This moves the declaration into the #ifdef section.
> 
> Fixes: 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/of/unittest.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied.