linux-kernel - Re: [PATCH] of: unittest: Remove VLA stack usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180317235304.eohpmrii3htlmann@rob-hp-laptop>
Date:   Sun, 18 Mar 2018 07:48:36 -0500
From:   Rob Herring <robh@...nel.org>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     Frank Rowand <frowand.list@...il.com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com,
        Tycho Andersen <tycho@...ho.ws>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] of: unittest: Remove VLA stack usage

On Mon, Mar 12, 2018 at 03:27:23PM +1100, Tobin C. Harding wrote:
> The kernel would like to have all stack VLA usage removed[1].  This is a
> test function so the execution speed is not critical.  We can allocate
> memory for this buffer instead of using a VLA.  If kmalloc() fails just
> return.
> 
> Allocate buffer with kmalloc().
> 
> [1]: https://lkml.org/lkml/2018/3/7/621
> 
> Signed-off-by: Tobin C. Harding <me@...in.cc>
> ---
> 
> Kees is this annoying you, CC'ing you an all my VLA patches?
> 
>  drivers/of/unittest.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)

Applied.

Rob