linux-kernel - Re: [PATCH] mfd: dt-bindings: Add PMIC reset property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180318125207.5dotrxc37owbeyyb@rob-hp-laptop>
Date:   Sun, 18 Mar 2018 07:52:07 -0500
From:   Rob Herring <robh@...nel.org>
To:     Daniel Schultz <d.schultz@...tec.de>
Cc:     mark.rutland@....com, heiko@...ech.de, w.egorov@...tec.de,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: dt-bindings: Add PMIC reset property

On Thu, Mar 15, 2018 at 11:58:50AM +0100, Daniel Schultz wrote:
> Add documentation about a new rk808 devicetree property, which can
> enable resets by the PMIC.

The subject needs to be more specific that this is for Rockchip PMIC.

> 
> Signed-off-by: Daniel Schultz <d.schultz@...tec.de>
> ---
>  Documentation/devicetree/bindings/mfd/rk808.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt
> index 91b6522..fa1a30f 100644
> --- a/Documentation/devicetree/bindings/mfd/rk808.txt
> +++ b/Documentation/devicetree/bindings/mfd/rk808.txt
> @@ -20,6 +20,8 @@ Optional properties:
>    default output clock name
>  - rockchip,system-power-controller: Telling whether or not this pmic is controlling
>    the system power.
> +- rockchip,system-reset-controller: Telling whether or not this pmic is controlling
> +  the system reset.

Would you ever really have power and reset controlled by different 
things? IOW, why do we need 2 properties?

Rob