linux-kernel - Re: [PATCH v12 00/11] Application Data Integrity feature introduced by SPARC M7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180318.110857.1660518649370410007.davem@davemloft.net>
Date:   Sun, 18 Mar 2018 11:08:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     khalid.aziz@...cle.com
Cc:     dave.hansen@...ux.intel.com, aarcange@...hat.com,
        akpm@...ux-foundation.org, allen.pais@...cle.com,
        aneesh.kumar@...ux.vnet.ibm.com, anthony.yznaga@...cle.com,
        arnd@...db.de, benh@...nel.crashing.org, bob.picco@...cle.com,
        bsingharora@...il.com, corbet@....net, dan.j.williams@...el.com,
        dave.jiang@...el.com, david.j.aldridge@...cle.com,
        dwindsor@...il.com, ebiederm@...ssion.com,
        elena.reshetova@...el.com, gregkh@...uxfoundation.org,
        hannes@...xchg.org, henry.willard@...cle.com, hpa@...or.com,
        hughd@...gle.com, imbrenda@...ux.vnet.ibm.com, jack@...e.cz,
        jag.raman@...cle.com, jane.chu@...cle.com, jglisse@...hat.com,
        jroedel@...e.de, khalid@...ehiking.org,
        khandual@...ux.vnet.ibm.com, kirill.shutemov@...ux.intel.com,
        kstewart@...uxfoundation.org, ktkhai@...tuozzo.com,
        liam.merwick@...cle.com, linux-arch@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linuxppc-dev@...ts.ozlabs.org,
        linuxram@...ibm.com, linux@...ck-us.net, me@...in.cc,
        mgorman@...e.de, mgorman@...hsingularity.net, mhocko@...e.com,
        mike.kravetz@...cle.com, minchan@...nel.org, mingo@...nel.org
Subject: Re: [PATCH v12 00/11] Application Data Integrity feature
 introduced by SPARC M7

From: Khalid Aziz <khalid.aziz@...cle.com>
Date: Wed, 21 Feb 2018 10:15:42 -0700

> V12 changes:
> This series is same as v10 and v11 and was simply rebased on 4.16-rc2
> kernel and patch 11 was added to update signal delivery code to use the
> new helper functions added by Eric Biederman. Can mm maintainers please
> review patches 2, 7, 8 and 9 which are arch independent, and
> include/linux/mm.h and mm/ksm.c changes in patch 10 and ack these if
> everything looks good? 

Khalid I've applied this series to sparc-next, thank you!

But one thing has to be fixed up.

In uapi/asm/auxvec.h you conditionalize the ADI aux vectors on
CONFIG_SPARC64.

That's not correct, you should never control user facing definitions
based upon kernel configuration.

Also, both 32-bit and 64-bit applications running on ADI capable
machines want to compile against and use this informaiton.

So please remove these CPP checks.