linux-kernel - Re: [PATCH v4 6/7] x86/hyper-v: detect nested features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1803181647420.1509@nanos.tec.linutronix.de>
Date:   Sun, 18 Mar 2018 16:47:55 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
cc:     kvm@...r.kernel.org, x86@...nel.org,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>,
        Mohammed Gamal <mmorsy@...hat.com>,
        Cathy Avery <cavery@...hat.com>, Bandan Das <bsd@...hat.com>,
        Christoph Hellwig <hch@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 6/7] x86/hyper-v: detect nested features

On Sun, 18 Mar 2018, Thomas Gleixner wrote:

> On Fri, 16 Mar 2018, Vitaly Kuznetsov wrote:
> >  
> > +	if (ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED)
> > +		ms_hyperv.nested_features =
> > +			cpuid_eax(HYPERV_CPUID_NESTED_FEATURES);
> 
> Please add curly braces. Rationale:
> 
>        https://marc.info/?l=linux-kernel&m=148467980905537
> 
> I know it's a pet pieve, ...

Other than that:

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>