linux-kernel - Re: [PATCH v1 0/2] PCI: Sparc 64-bit resource fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180318.120734.1936832399192758981.davem@davemloft.net>
Date:   Sun, 18 Mar 2018 12:07:34 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     helgaas@...nel.org
Cc:     khalid.aziz@...cle.com, sparclinux@...r.kernel.org,
        linux-pci@...r.kernel.org, yinghai@...nel.org,
        linux-kernel@...r.kernel.org, david.ahern@...cle.com, linux@....tj
Subject: Re: [PATCH v1 0/2] PCI: Sparc 64-bit resource fixups

From: Bjorn Helgaas <helgaas@...nel.org>
Date: Tue, 20 Feb 2018 17:39:35 -0600

> Both these patches are on my pci/sparc branch and appeared in the
> Feb 19 linux-next tree.
> 
> Any testing and feedback (especially on the second patch, which should
> change /proc/iomem) would be great.
> 
> They're headed for v4.17 unless I hear about issues.
> 
> It would be useful to hear about what's still broken so I can try to
> pull in the other patches.

I don't understand why you put the SYSTEM and Video ROM at addresses
relative to absolute zero.  The result of this is that it might
overlap real physical memory.

If a VGA card is present, it's ROM will respond to those addresses
relative to the PCI controller's MEM space area.

Their legacy resources are "hardwired", but those hardwired addresses
need to be relative to the PCI host controller's MEM areas in order
for them to be accessible.

I could understand removing the System ROM resource altogether, that
makes a lot of sense to me.

Thanks.