linux-kernel - Re: [PATCH v6 07/15] fs, dax: use page->mapping to warn if truncate collides with a busy page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201803181442.ZhdoKejk%fengguang.wu@intel.com>
Date:   Sun, 18 Mar 2018 14:26:47 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     kbuild-all@...org, linux-nvdimm@...ts.01.org,
        Jeff Moyer <jmoyer@...hat.com>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Jan Kara <jack@...e.cz>, Christoph Hellwig <hch@....de>,
        david@...morbit.com, linux-xfs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 07/15] fs, dax: use page->mapping to warn if truncate
 collides with a busy page

Hi Dan,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc5 next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Dan-Williams/dax-fix-dma-vs-truncate-hole-punch/20180318-050250
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All error/warnings (new ones prefixed by >>):

   fs/dax.c: In function 'dax_entry_size':
>> fs/dax.c:308:10: error: 'HPAGE_SIZE' undeclared (first use in this function); did you mean 'PAGE_SIZE'?
      return HPAGE_SIZE;
             ^~~~~~~~~~
             PAGE_SIZE
   fs/dax.c:308:10: note: each undeclared identifier is reported only once for each function it appears in
>> fs/dax.c:311:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +308 fs/dax.c

   300	
   301	static unsigned long dax_entry_size(void *entry)
   302	{
   303		if (dax_is_zero_entry(entry))
   304			return 0;
   305		else if (dax_is_empty_entry(entry))
   306			return 0;
   307		else if (dax_is_pmd_entry(entry))
 > 308			return HPAGE_SIZE;
   309		else
   310			return PAGE_SIZE;
 > 311	}
   312	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (53197 bytes)