linux-kernel - Re: [PATCH v2] clang-format: add configuration file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1521397579.27411.39.camel@perches.com>
Date:   Sun, 18 Mar 2018 11:26:19 -0700
From:   Joe Perches <joe@...ches.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Andy Whitcroft <apw@...onical.com>,
        Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] clang-format: add configuration file

On Sun, 2018-03-18 at 18:16 +0100, Miguel Ojeda wrote:
>   * Uses clang's tooling support behind the scenes to parse and rewrite
>     the code. It is not based on ad-hoc regexps.

Did you look at the results of a typical and generally
style conforming
subsystem when reformatted with the new
rules you propose here with
clang-format?

One of the issues with hard-n-fast code formatters like
clang-format is taste.

clang-format doesn't have any so it can't know when _not_
to  reformat blocks according to its rules.

Tools like clang-format are generally fine for a first-pass
reformat of non-style compliant code, but are IMO generally
unsuitable for continuous automated use.