linux-kernel - Re: [PATCH v3 11/20] firmware: enable to force disable the fallback mechanism at run time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB=NE6UWSdEUVzDo_stzkb2C8_FRZo9sS5d6oq9QJRME+JrGOw@mail.gmail.com>
Date:   Sun, 18 Mar 2018 13:20:29 -0700
From:   "Luis R. Rodriguez" <mcgrof@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Bitterblue of Monsea <cantabile.desu@...il.com>,
        kubakici@...pl, linux-wireless <linux-wireless@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>, shuah@...nel.org,
        Martin Fuzzey <mfuzzey@...keon.com>,
        Mimi Zohar <zohar@...ux.vnet.ibm.com>,
        David Howells <dhowells@...hat.com>,
        Pali Rohár <pali.rohar@...il.com>,
        Takashi Iwai <tiwai@...e.de>,
        Arend Van Spriel <arend.vanspriel@...adcom.com>,
        Rafał Miłecki <zajec5@...il.com>,
        Nicolas Broeking <nbroeking@...com>,
        Vikram Mulukutla <markivx@...eaurora.org>,
        Mark Brown <broonie@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Abhay Salunke <Abhay_Salunke@...l.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        jewalt@...innovations.com, oneukum@...e.com,
        Alexei Starovoitov <ast@...com>,
        Andres Rodriguez <andresx7@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v3 11/20] firmware: enable to force disable the fallback
 mechanism at run time

On Wed, Mar 14, 2018 at 12:00 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Sat, Mar 10, 2018 at 06:14:52AM -0800, Luis R. Rodriguez wrote:
>> You currently need four different kernel builds to test the firmware
>> API fully. By adding a proc knob to force disable the fallback mechanism
>> completely we are able to reduce the amount of kernels you need built
>> to test the firmware API down to two.
>>
>> Acked-by: Kees Cook <keescook@...omium.org>
>> Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
>> ---
>>  drivers/base/firmware_loader/fallback.c       | 5 +++++
>>  drivers/base/firmware_loader/fallback.h       | 4 ++++
>>  drivers/base/firmware_loader/fallback_table.c | 9 +++++++++
>>  3 files changed, 18 insertions(+)
>>
>> diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c
>> index 45cc40933a47..d6838e7ec00c 100644
>> --- a/drivers/base/firmware_loader/fallback.c
>> +++ b/drivers/base/firmware_loader/fallback.c
>> @@ -643,6 +643,11 @@ static bool fw_force_sysfs_fallback(unsigned int opt_flags)
>>
>>  static bool fw_run_sysfs_fallback(unsigned int opt_flags)
>>  {
>> +     if (fw_fallback_config.ignore_sysfs_fallback) {
>> +             pr_info_once("Ignoring firmware sysfs fallback due to debugfs knob\n");
>
> s/debugfs/sysctl/ right?

Indeed. Will respin with the other space fix. As for the other changes
let me know if you have further feedback or if I should just keep them
as-is.

  Luis