linux-kernel - Re: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180318102417.GA30164@kroah.com>
Date:   Sun, 18 Mar 2018 11:24:17 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Vinod Koul <vinod.koul@...el.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        Eric Anholt <eric@...olt.net>,
        Sasha Levin <alexander.levin@...rosoft.com>
Subject: Re: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use
 vchan_terminate_vdesc() instead of desc_free

On Sat, Mar 17, 2018 at 08:02:57PM +0530, Vinod Koul wrote:
> On Fri, Mar 16, 2018 at 01:46:40PM -0500, Dan Rue wrote:
> > On Fri, Mar 16, 2018 at 04:23:33PM +0100, Greg Kroah-Hartman wrote:
> > > 4.14-stable review patch.  If anyone has any objections, please let me know.
> > > 
> > > ------------------
> > > 
> > > From: Peter Ujfalusi <peter.ujfalusi@...com>
> > > 
> > > 
> > > [ Upstream commit de92436ac40ffe9933230aa503e24dbb5ede9201 ]
> > > 
> > > To avoid race with vchan_complete, use the race free way to terminate
> > > running transfer.
> > > 
> > > Implement the device_synchronize callback to make sure that the terminated
> > > descriptor is freed.
> > > 
> > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> > > Acked-by: Eric Anholt <eric@...olt.net>
> > > Signed-off-by: Vinod Koul <vinod.koul@...el.com>
> > > Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > This patch is causing a build error on arm and arm64 per i.e.
> > https://kernelci.org/build/id/5aac017e59b5141cb1b3a4d5/
> > 
> > Builds are also failing for arm/arm64 on 4.15 and this patch seems to be a
> > problem there as well, but I have not verified it yet.
> 
> I think we are missing commit 1c7f072d94e8. Pls cherrypick that as well
> 
> commit 1c7f072d94e8b697fd9b70cdb268622a18faf522
> Author: Peter Ujfalusi <peter.ujfalusi@...com>
> Date:   Tue Nov 14 16:32:04 2017 +0200
> 
>     dmaengine: virt-dma: Support for race free transfer termination
> 
> This adds vchan_terminate_vdesc API..

Thanks, that helped.  I've now added this and send out a -rc2 for this
kernel.

greg k-h