linux-kernel - Re: [PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180319175328.GF1225@ziepe.ca>
Date:   Mon, 19 Mar 2018 11:53:28 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Honggang LI <honli@...hat.com>
Cc:     dledford@...hat.com, matanb@...lanox.com, leonro@...lanox.com,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        noaos@...lanox.com
Subject: Re: [PATCH] IB/mlx5: Set the default active rate and width to QDR
 and 4X

On Fri, Mar 16, 2018 at 10:37:13AM +0800, Honggang LI wrote:
> From: Honggang Li <honli@...hat.com>
> 
> commit f1b65df5a232 ("IB/mlx5: Add support for active_width and
> active_speed in RoCE"). Before this patch applied, the mlx5_ib
> driver set default active_width and active_speed to IB_WIDTH_4X
> and IB_SPEED_QDR.
> 
> When the RoCE port is down, the RoCE port did not negotiate the
> active width with remote side. The active width is zero. If run
> ibstat to require the port status, ibstat will panic as it read
> invalid width from sys file.
> 
> This patch restores the original behavior.
> 
> Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE").
> Signed-off-by: Honggang Li <honli@...hat.com>
> Reviewed-by: Hal Rosenstock <hal@...lanox.com>
> Reviewed-by: Noa Osherovich <noaos@...lanox.com>
>  drivers/infiniband/hw/mlx5/main.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied to for-next, thanks

Jason