linux-kernel - Re: [PATCH 4.14 056/109] clk: ti: clkctrl: add support for retrying failed init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Mar 2018 08:24:07 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Tero Kristo <t-kristo@...com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Stephen Boyd <sboyd@...eaurora.org>,
        Sasha Levin <alexander.levin@...rosoft.com>
Subject: Re: [PATCH 4.14 056/109] clk: ti: clkctrl: add support for retrying
 failed init

On Mon, Mar 19, 2018 at 08:57:30AM +0200, Tero Kristo wrote:
> On 19/03/18 05:44, Dan Rue wrote:
> > On Fri, Mar 16, 2018 at 04:23:25PM +0100, Greg Kroah-Hartman wrote:
> > > 4.14-stable review patch.  If anyone has any objections, please let me know.
> > > 
> > > ------------------
> > > 
> > > From: Tero Kristo <t-kristo@...com>
> > > 
> > > 
> > > [ Upstream commit 729e13bf58e643b9accd2a14c55b555958702fb0 ]
> > > 
> > > In case the clkctrl node contains assigned-clock-* entries, registering
> > > the provider can fail with -EPROBE_DEFER. In this case, add the
> > > provider to the retry_init clock list so it will be cleaned up later.
> > > 
> > > Signed-off-by: Tero Kristo <t-kristo@...com>
> > > Acked-by: Stephen Boyd <sboyd@...eaurora.org>
> > > Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > This fails to build for me on arm32:
> > 
> > $ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm multi_v7_defconfig
> > $ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm
> 
> This actually needs commit ffb009b24388b896d9ca8b54e39a879302142518 ("clk:
> ti: convert retry_init param to use void data type") as prerequisite,
> otherwise it fails building.

Thanks, I'll just drop this patch from the trees now, as that seems to
make more sense.

Sasha, if you want to pick both of these up for your next round of
patches to submit, that's fine.

thanks,

greg k-h