linux-kernel - Re: [PATCH v2 0/2] PCI: Update quirk timing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180319185119.GD77194@bhelgaas-glaptop.roam.corp.google.com>
Date:   Mon, 19 Mar 2018 13:51:19 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     linux-pci@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Myron Stowe <myron.stowe@...hat.com>,
        Paul Menzel <pmenzel+linux-pci@...gen.mpg.de>,
        Andreas Noever <andreas.noever@...il.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v2 0/2] PCI: Update quirk timing

On Wed, Mar 14, 2018 at 08:30:26AM -0500, Bjorn Helgaas wrote:
> This is a minor update of a patch I posted earlier [1] when Paul
> reported an unreasonably long time spent in PCI quirks during boot
> [2].  This doesn't fix the slow quirks, but might help find them.
> 
> We previously printed the time taken by each quirk if "initcall_debug"
> was specified.  With these patches, we'll print it even without
> "initcall_debug" if the quirk takes longer than 10ms.
> 
> I did notice one quirk (quirk_apple_poweroff_thunderbolt()) in the
> suspend path that sleeps for 300ms, so this will probably make suspend
> noisier on Apple systems.
> 
> [1] https://lkml.kernel.org/r/20171228212723.GB211339@bhelgaas-glaptop.roam.corp.google.com
> [2] https://lkml.kernel.org/r/44cada166e42007d27b4c3e3aa0744d7@molgen.mpg.de
> 
> ---
> 
> Bjorn Helgaas (2):
>       PCI: Report quirk timings with pci_info() instead of pr_debug()
>       PCI: Report quirks that take more than 10ms
> 
> 
>  drivers/pci/quirks.c |   24 ++++++++----------------
>  1 file changed, 8 insertions(+), 16 deletions(-)

Applied to pci/misc for v4.17.