linux-kernel - RE: [PATCH v5 11/11] KVM: x86: Disable Intel Processor Trace when VMXON in L1 guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82D7661F83C1A047AF7DC287873BF1E167EFC16F@SHSMSX101.ccr.corp.intel.com>
Date:   Mon, 19 Mar 2018 07:31:49 +0000
From:   "Kang, Luwei" <luwei.kang@...el.com>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
CC:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "joro@...tes.org" <joro@...tes.org>
Subject: RE: [PATCH v5 11/11] KVM: x86: Disable Intel Processor Trace when
 VMXON in L1 guest

> > +	if (pt_mode == PT_MODE_HOST_GUEST) {
> 
> This would be vmx_pt_supported(), but I think it's better to remove that function and just test pt_mode ==
> PT_MODE_HOST_GUEST everywhere (or !=).

Hi Paolo,
    There have so many vmx_pt_supported() invoked in MSRs read/write (patch 9) patch and I think it can be replaced by  pt_mode check.
    But I think this function need to be reserved in patch 5(cpuid emulation). What is your opinion?

Thanks,
Luwei Kang

> 
> Paolo
> 
> > +		vmx->pt_desc.guest.ctl = 0;
> > +		vmcs_write64(GUEST_IA32_RTIT_CTL, 0);
> > +		pt_set_intercept_for_msr(vmx, 1);
> > +	}
> > +