linux-kernel - Re: [PATCH] ALSA: usb-audio: Fix parsing descriptor of UAC2 processing unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Mar 2018 08:47:49 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc:     "Kirill Marinushkin" <k.marinushkin@...il.com>,
        <alsa-devel@...a-project.org>,
        "Ruslan Bilovol" <ruslan.bilovol@...il.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Felipe Balbi" <felipe.balbi@...ux.intel.com>,
        "Philippe Ombredanne" <pombredanne@...b.com>,
        "Jaroslav Kysela" <perex@...ex.cz>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Fix parsing descriptor of UAC2 processing unit

On Mon, 19 Mar 2018 08:40:19 +0100,
Greg Kroah-Hartman wrote:
> 
> On Mon, Mar 19, 2018 at 07:11:08AM +0100, Kirill Marinushkin wrote:
> > Currently, the offsets in the UAC2 processing unit descriptor are
> > calculated incorrectly. It causes an issue when connecting the device which
> > provides such a feature:
> > 
> > ~~~~
> > [84126.724420] usb 1-1.3.1: invalid Processing Unit descriptor (id 18)
> > ~~~~
> > 
> > After this patch is applied, the UAC2 processing unit inits w/o this error.
> > 
> > Fixes: 5e1ddb481776 ("UAPI: (Scripted) Disintegrate include/linux/usb")
> > Signed-off-by: Kirill Marinushkin <k.marinushkin@...il.com>
> > Cc: Mark Brown <broonie@...nel.org>
> > Cc: Jaroslav Kysela <perex@...ex.cz>
> > Cc: Takashi Iwai <tiwai@...e.com>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Felipe Balbi <felipe.balbi@...ux.intel.com>
> > Cc: Philippe Ombredanne <pombredanne@...b.com>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Ruslan Bilovol <ruslan.bilovol@...il.com>
> > Cc: linux-kernel@...r.kernel.org
> > Cc: alsa-devel@...a-project.org
> > ---
> >  include/uapi/linux/usb/audio.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> 	Cc: stable <stable@...r.kernel.org>
>  perhaps?

Yes, it deserves.  But I'd need to double-check the UAC2
specification.  It's interesting that such a basic thing hasn't hit
until now.  Maybe just because it's a fairly minor feature.


thanks,

Takashi