linux-kernel - Re: [PATCH] clk: clk-gpio: Allow GPIO to sleep in set/get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Mar 2018 13:53:33 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Mike Looijmans <mike.looijmans@...ic.nl>, linux-clk@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, mturquette@...libre.com,
        Mike Looijmans <mike.looijmans@...ic.nl>
Subject: Re: [PATCH] clk: clk-gpio: Allow GPIO to sleep in set/get_parent

Quoting Mike Looijmans (2018-03-13 01:54:03)
> When changing or retrieving clock parents, the caller is in a sleepable
> state (like prepare) so the GPIO operation need not be atomic. Replace
> gpiod_{g|s}et_value with gpiod_{g|s}et_value_cansleep in the {g|s}et_parent
> calls for the GPIO based clock mux.
> 
> This fixes a "slowpath" warning when the GPIO controller is an I2C expander
> or something similar.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
> ---

Applied to clk-next