linux-kernel - Re: [PATCH] regulator: fix platform_no_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Mar 2018 14:47:29 -0700
From:   David Collins <collinsd@...eaurora.org>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, broonie@...nel.org, lgirdwood@...il.com,
        robh+dt@...nel.org, mark.rutland@....com,
        linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, rnayak@...eaurora.org,
        sboyd@...nel.org
Subject: Re: [PATCH] regulator: fix platform_no_drv_owner.cocci warnings

On 03/18/2018 01:38 PM, kbuild test robot wrote:
> From: Fengguang Wu <fengguang.wu@...el.com>
> 
> drivers/regulator/qcom_rpmh-regulator.c:1104:3-8: 
> No need to set .owner here. The core will do it.

Thanks for pointing this out.

> --- a/drivers/regulator/qcom_rpmh-regulator.c
> +++ b/drivers/regulator/qcom_rpmh-regulator.c
> @@ -1101,7 +1101,6 @@ static struct platform_driver rpmh_regul
>  	.driver		= {
>  		.name		= "qcom-rpmh-regulator",
>  		.of_match_table	= rpmh_regulator_match_table,
> -		.owner		= THIS_MODULE,
>  	},
>  	.probe		= rpmh_regulator_probe,
>  	.remove		= rpmh_regulator_remove,

I'll make this modification in [1] if I end up sending out a second
version of the patch.

Take care,
David

[1]: https://lkml.org/lkml/2018/3/16/1430

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project