[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180319021323.GD27186@ziepe.ca>
Date: Sun, 18 Mar 2018 20:13:23 -0600
From: Jason Gunthorpe <jgg@...pe.ca>
To: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc: linux-integrity@...r.kernel.org,
linux-security-module@...r.kernel.org, Sahil Rihan <srihan@...com>,
Alexei Starovoitov <ast@...com>, stable@...r.kernel.org,
Peter Huewe <peterhuewe@....de>, Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tpm: allow TCPA log area to be empty
On Fri, Mar 16, 2018 at 02:55:25PM +0200, Jarkko Sakkinen wrote:
> On Mon, Mar 12, 2018 at 09:02:32AM -0600, Jason Gunthorpe wrote:
> > On Sat, Mar 10, 2018 at 06:16:37PM +0200, Jarkko Sakkinen wrote:
> > > TCPA log are can be empty when the TPM is disabled. This commit changes the
> > > behavior of tpm_read_log_acpi() to return successfully in this case.
> >
> > The commit should explain why we'd want this..
> >
> > eg Why does it matter to create the extra sysfs files to report an empty
> > log?
> >
> > Jason
>
> The initialization of the driver will fail otherwise. Not sure if I
> understand your question.
Well, I mean in the sense of what is broken and why is this the right
fix. Why not return -ENODEV?
Jason
Powered by blists - more mailing lists