linux-kernel - Re: [PATCH] acpi, numa: fix pxm to online numa node associations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1521472904.2693.192.camel@hpe.com>
Date:   Mon, 19 Mar 2018 15:21:52 +0000
From:   "Kani, Toshi" <toshi.kani@....com>
To:     "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "toshi.kani@...com" <toshi.kani@...com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH] acpi, numa: fix pxm to online numa node associations

On Thu, 2018-03-15 at 20:08 -0700, Dan Williams wrote:
> Commit 99759869faf1 "acpi: Add acpi_map_pxm_to_online_node()" added
> support for mapping a given proximity to its nearest, by SLIT distance,
> online node. However, it sometimes returns unexpected results due to the
> fact that it switches from comparing the PXM node to the last node that
> was closer than the current max.
> 
>     for_each_online_node(n) {
>             dist = node_distance(node, n);
>             if (dist < min_dist) {
>                     min_dist = dist;
>                     node = n;	<---- from this point we're using the
> 				      wrong node for node_distance()

ouch...

> 
> 
> Fixes: 99759869faf1 ("acpi: Add acpi_map_pxm_to_online_node()")
> Cc: <stable@...r.kernel.org>
> Cc: Toshi Kani <toshi.kani@...com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Thanks Dan for the fix!

Reviewed-by: Toshi Kani <toshi.kani@....com>

-Toshi