linux-kernel - Re: [PATCH 1/5] Staging: rtl8723bs: os

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180319154344.GA30651@kroah.com>
Date:   Mon, 19 Mar 2018 16:43:44 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Paul McQuade <paulmcquad@...il.com>
Cc:     devel@...verdev.osuosl.org, keescook@...omium.org,
        johannes.berg@...el.com, linux-kernel@...r.kernel.org,
        Linyu.Yuan@...atel-sbell.com.cn, hdegoede@...hat.com,
        arnd@...db.de, arvind.yadav.cs@...il.com, colin.king@...onical.com,
        davem@...emloft.net, Larry.Finger@...inger.net
Subject: Re: [PATCH 1/5] Staging: rtl8723bs: os_dep

On Mon, Mar 19, 2018 at 02:34:56PM +0000, Paul McQuade wrote:
> ERROR: do not initialise statics to NULL

You are going to have to do a bit more writing in the changelog than
just dumping in random output from checkpatch.pl.  I know that's where
that line came from, but no one else will.

And your subject lines also need a lot of work.

Please fix up for all of these patches and resend the whole series.

thanks,

greg k-h