linux-kernel - [PATCH] irqchip: irq-gic-v4: return real error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Mar 2018 19:38:14 +0800
From:   Peng Hao <peng.hao2@....com.cn>
To:     tglx@...utronix.de, jason@...edaemon.net, marc.zyngier@....com
Cc:     linux-kernel@...r.kernel.org, Peng Hao <peng.hao2@....com.cn>
Subject: [PATCH] irqchip: irq-gic-v4: return real error code

__irq_domain_alloc_irqs will return some different error code, so we
should return real error code in its_alloc_vcpu_irqs.

Signed-off-by: Peng Hao <peng.hao2@....com.cn>
---
 drivers/irqchip/irq-gic-v4.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-gic-v4.c b/drivers/irqchip/irq-gic-v4.c
index dba9d67..ecd170d 100644
--- a/drivers/irqchip/irq-gic-v4.c
+++ b/drivers/irqchip/irq-gic-v4.c
@@ -99,7 +99,7 @@
 
 int its_alloc_vcpu_irqs(struct its_vm *vm)
 {
-	int vpe_base_irq, i;
+	int vpe_base_irq, i, ret = -ENOMEM;
 
 	vm->fwnode = irq_domain_alloc_named_id_fwnode("GICv4-vpe",
 						      task_pid_nr(current));
@@ -120,8 +120,10 @@ int its_alloc_vcpu_irqs(struct its_vm *vm)
 	vpe_base_irq = __irq_domain_alloc_irqs(vm->domain, -1, vm->nr_vpes,
 					       NUMA_NO_NODE, vm,
 					       false, NULL);
-	if (vpe_base_irq <= 0)
+	if (vpe_base_irq <= 0) {
+		ret = vpe_base_irq;
 		goto err;
+	}
 
 	for (i = 0; i < vm->nr_vpes; i++)
 		vm->vpes[i]->irq = vpe_base_irq + i;
@@ -134,7 +136,7 @@ int its_alloc_vcpu_irqs(struct its_vm *vm)
 	if (vm->fwnode)
 		irq_domain_free_fwnode(vm->fwnode);
 
-	return -ENOMEM;
+	return ret;
 }
 
 void its_free_vcpu_irqs(struct its_vm *vm)
-- 
1.8.3.1