linux-kernel - Re: [PATCH 5/6] staging: ks7010: Fix line over 80 characters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1521526087.12047.1.camel@perches.com>
Date:   Mon, 19 Mar 2018 23:08:07 -0700
From:   Joe Perches <joe@...ches.com>
To:     Quytelda Kahja <quytelda@...alin.org>, gregkh@...uxfoundation.org,
        wsa@...-dreams.de
Cc:     driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] staging: ks7010: Fix line over 80 characters.

On Mon, 2018-03-19 at 22:58 -0700, Quytelda Kahja wrote:
> There is no reason for comment describing the BSSID check for loop
> to be spaced so far to the right.  Move it above the for loop.
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -844,7 +844,8 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
>  	ap_info = (struct ap_info_t *)(priv->rxp);
>  
>  	if (priv->scan_ind_count) {
> -		for (i = 0; i < priv->aplist.size; i++) {	/* bssid check */
> +		/* bssid check */
> +		for (i = 0; i < priv->aplist.size; i++) {
>  			if (memcmp(ap_info->bssid,
>  				   priv->aplist.ap[i].bssid, ETH_ALEN) != 0)

this could also use ether_addr_equal