linux-kernel - Re: [PATCH 2/6] phy: qcom-qusb2: Fix crash if nvmem cell not specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24bc718a-10cd-6fd7-aa16-af201c08f17f@codeaurora.org>
Date:   Tue, 20 Mar 2018 15:42:16 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Manu Gautam <mgautam@...eaurora.org>,
        Kishon Vijay Abraham I <kishon@...com>
Cc:     linux-arm-msm@...r.kernel.org,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        "open list:GENERIC PHY FRAMEWORK" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] phy: qcom-qusb2: Fix crash if nvmem cell not
 specified

Hi Manu,


On 3/16/2018 3:14 PM, Manu Gautam wrote:
> Driver currently crashes due to NULL pointer deference
> while updating PHY tune register if nvmem cell is NULL.
> Since, fused value for Tune1/2 register is optional,
> we'd rather bail out.

fixes: ("ca04d9d3e1b1 phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom 
chips") ?
and please CC to stable as well - ver 4.14.

With that,
Reviewed-by: Vivek Gautam <vivek.gautam@...eaurora.org>

Thanks
Vivek
>
> Signed-off-by: Manu Gautam <mgautam@...eaurora.org>
> ---
>   drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> index 94afeac..40fdef8 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> @@ -315,6 +315,10 @@ static void qusb2_phy_set_tune2_param(struct qusb2_phy *qphy)
>   	const struct qusb2_phy_cfg *cfg = qphy->cfg;
>   	u8 *val;
>   
> +	/* efuse register is optional */
> +	if (!qphy->cell)
> +		return;
> +
>   	/*
>   	 * Read efuse register having TUNE2/1 parameter's high nibble.
>   	 * If efuse register shows value as 0x0, or if we fail to find