linux-kernel - Re: [PATCH v8 01/12] drivers: base: Unified device connection lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb9950fe-54fd-eda8-e678-f2216204f62f@redhat.com>
Date:   Tue, 20 Mar 2018 13:21:57 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Guenter Roeck <linux@...ck-us.net>, Jun Li <jun.li@....com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v8 01/12] drivers: base: Unified device connection lookup

Hi,

On 20-03-18 11:32, Heikki Krogerus wrote:
> On Tue, Mar 20, 2018 at 12:04:12PM +0200, Heikki Krogerus wrote:
>>>> +void device_connection_remove(struct device_connection *con)
>>>> +{
>>>> +	mutex_lock(&devcon_lock);
>>>> +	list_del_rcu(&con->list);
>>>
>>> See, rcu?
>>
>> True. I'll send one more version.
> 
> Before I do that, Hans, can you quickly check this and see that I
> have not made any more mistakes? I don't trust myself anymore with
> these.

This looks good to me (note I did not test only reviewed).

Regards,

Hans