linux-kernel - Re: [PATCH v5 09/12] clk: actions: Add fixed factor clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <152156612855.183971.17769572831805053841@swboyd.mtv.corp.google.com>
Date:   Tue, 20 Mar 2018 10:15:28 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     mark.rutland@....com, devicetree@...r.kernel.org,
        daniel.thompson@...aro.org, manivannanece23@...il.com,
        bdong@...obotics.com, viresh.kumar@...aro.org,
        mturquette@...libre.com, 96boards@...obotics.com,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        amit.kucheria@...aro.org, davem@...emloft.net,
        hzhang@...obotics.com, robh+dt@...nel.org, mp-cs@...ions-semi.com,
        liuwei@...ions-semi.com, mchehab@...nel.org, afaerber@...e.de,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 09/12] clk: actions: Add fixed factor clock support

Quoting Manivannan Sadhasivam (2018-03-20 02:04:00)
> On Mon, Mar 19, 2018 at 06:10:03PM -0700, Stephen Boyd wrote:
> > > +        * nop.
> > > +        */
> > > +
> > > +       return 0;
> > > +}
> > > +
> > > +const struct clk_ops owl_fix_fact_ops = {
> > > +       .round_rate     = owl_fix_fact_round_rate,
> > > +       .recalc_rate    = owl_fix_fact_recalc_rate,
> > > +       .set_rate       = owl_fix_fact_set_rate,
> > > +};
> > 
> > Why can't you use the regular fixed factor clk code and ops?
> >
> 
> That's going to be really messy. Since I'm having the clk_hw embedded inside
> owl_clk_common and using it for registering all the clocks, using generic
> fixed factor functions will be a different approach _only_ for this clock and
> it won't look good I guess. Also, it may become complicated with composite
> clocks.
> 
> If you still want to use the generic fixed factor code, I can do that in
> next revision.
> 

The qcom clk driver has support for the 'regmap' clk_hws and the
non-regmap based clk_hws. I suggest having a list of clk_hw pointers
that you register in a loop and then have other lists that you use to
register wrapper structs, etc. Otherwise we're left with a bunch of code
that's copy/pasted around.